Parse working_dir switch #195
Conversation
- parse output path and component to run as switch -o and --component
lib/cli.ex
Outdated
|
|
||
| parsed_switches | ||
| |> Keyword.get(:working_dir, File.cwd!()) | ||
| |> module.main |
There was a problem hiding this comment.
The Elixir style guide suggests using parentheses in the pipe operator.
Use parentheses for one-arity functions when using the pipe operator (
|>).
| |> module.main | |
| |> module.main() |
I’d generally incline towards using them for functions without an argument, mainly for consistency. The Guide considers that preferred, although in other examples they use them without parens a lot themselves.
Use parentheses in function calls, especially inside a pipeline.
--working-dir is switch which allow user use different working directory than only current working directory
Glutexo
force-pushed
the
parse-working-dir
branch
from
81546fb to
8f80dca
Compare
Glutexo
force-pushed
the
parse-working-dir
branch
from
8f80dca to
4e5fa37
Compare
- working_dir is more precise naming for the intend purpose, - working_dir is also name of the switch we use on CLI
|
DONT FORGET TO TESTS!! |
|
Test lowercase |
|
Reade for review I've already merged #223 to this PR! |
nappex
force-pushed
the
parse-working-dir
branch
from
95303f2 to
47e06ed
Compare
|
Just discovered a Mix.Shell module that has a cmd function with a Update: I took a look and Mix.Shell.cmd/3 can be used to make Mix run a shell command. |
Co-authored-by: Glutexo <driezasson@me.com>
fix #182